1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197"""Integration tests for the by-job-id PII decision endpoints.
Covers POST /api/v1/documents/{job_id}/pii/approve and
POST /api/v1/documents/{job_id}/pii/deny — the variants the Canvas LTI
connector consumes. The token-based equivalent at
/api/v1/approval/{token}/decision is covered by test_approval_flow.py.
"""
from unittest.mock import AsyncMock, patch
import pytest
from httpx import ASGITransport, AsyncClient
from src.dependencies import (
get_redis_client,
get_s3_url_service,
get_storage_service,
)
from src.main import app
@pytest.fixture
def job_id():
return "550e8400-e29b-41d4-a716-446655440000"
@pytest.fixture
def awaiting_approval_job(job_id):
return {
"job_id": job_id,
"s3_key": "temp/test-doc.pdf",
"status": "awaiting_approval",
}
@pytest.fixture
def decided_job(job_id):
"""Job that already moved past awaiting_approval — should trigger 409."""
return {
"job_id": job_id,
"s3_key": "temp/test-doc.pdf",
"status": "processing_queued",
}
@pytest.fixture
def post_body():
return {
"justification": "Author bylines and citations — not student PII.",
"reviewed_by": "faculty@example.edu",
}
def _override_deps(mock_redis: AsyncMock) -> None:
"""Wire dependency_overrides for redis + storage + s3 url services."""
app.dependency_overrides[get_redis_client] = lambda: mock_redis
app.dependency_overrides[get_storage_service] = lambda: AsyncMock()
app.dependency_overrides[get_s3_url_service] = lambda: AsyncMock()
@pytest.mark.integration
@pytest.mark.asyncio
async def test_approve_pii_happy_path(
job_id, awaiting_approval_job, post_body, api_key_headers
):
"""Happy path: existing awaiting_approval job → 200, status flipped to processing_queued."""
mock_redis = AsyncMock()
_override_deps(mock_redis)
mock_job_service = AsyncMock()
mock_job_service.get_job.return_value = awaiting_approval_job
mock_approval_service = AsyncMock()
try:
with (
patch("src.api.documents.JobService", return_value=mock_job_service),
patch("src.api.documents.ApprovalService", return_value=mock_approval_service),
):
async with AsyncClient(
transport=ASGITransport(app=app), base_url="http://test"
) as client:
response = await client.post(
f"/api/v1/documents/{job_id}/pii/approve",
json=post_body,
headers=api_key_headers,
)
assert response.status_code == 200
body = response.json()
assert body["decision"] == "approved"
assert body["job_id"] == job_id
assert "approved" in body["message"].lower()
mock_approval_service.quick_approve.assert_awaited_once_with(job_id)
finally:
app.dependency_overrides.clear()
@pytest.mark.integration
@pytest.mark.asyncio
async def test_deny_pii_happy_path(
job_id, awaiting_approval_job, post_body, api_key_headers
):
"""Happy path: deny → 200, quick_deny called once."""
mock_redis = AsyncMock()
_override_deps(mock_redis)
mock_job_service = AsyncMock()
mock_job_service.get_job.return_value = awaiting_approval_job
mock_approval_service = AsyncMock()
try:
with (
patch("src.api.documents.JobService", return_value=mock_job_service),
patch("src.api.documents.ApprovalService", return_value=mock_approval_service),
):
async with AsyncClient(
transport=ASGITransport(app=app), base_url="http://test"
) as client:
response = await client.post(
f"/api/v1/documents/{job_id}/pii/deny",
json=post_body,
headers=api_key_headers,
)
assert response.status_code == 200
body = response.json()
assert body["decision"] == "denied"
assert body["job_id"] == job_id
assert "denied" in body["message"].lower()
mock_approval_service.quick_deny.assert_awaited_once_with(job_id)
finally:
app.dependency_overrides.clear()
@pytest.mark.integration
@pytest.mark.asyncio
async def test_approve_pii_job_not_found(job_id, post_body, api_key_headers):
"""JobService.get_job returns None → 404."""
mock_redis = AsyncMock()
_override_deps(mock_redis)
mock_job_service = AsyncMock()
mock_job_service.get_job.return_value = None
try:
with patch("src.api.documents.JobService", return_value=mock_job_service):
async with AsyncClient(
transport=ASGITransport(app=app), base_url="http://test"
) as client:
response = await client.post(
f"/api/v1/documents/{job_id}/pii/approve",
json=post_body,
headers=api_key_headers,
)
assert response.status_code == 404
assert job_id in response.json()["detail"]
finally:
app.dependency_overrides.clear()
@pytest.mark.integration
@pytest.mark.asyncio
async def test_approve_pii_already_decided_returns_409(
job_id, decided_job, post_body, api_key_headers
):
"""Job exists but isn't in awaiting_approval → 409.
This is the contract the Canvas LTI connector relies on to surface
"another instructor already decided in a parallel tab" as a 409 to the
operator. Without this pre-check, ``quick_approve`` would silently
overwrite the already-decided state.
"""
mock_redis = AsyncMock()
_override_deps(mock_redis)
mock_job_service = AsyncMock()
mock_job_service.get_job.return_value = decided_job
mock_approval_service = AsyncMock()
try:
with (
patch("src.api.documents.JobService", return_value=mock_job_service),
patch("src.api.documents.ApprovalService", return_value=mock_approval_service),
):
async with AsyncClient(
transport=ASGITransport(app=app), base_url="http://test"
) as client:
response = await client.post(
f"/api/v1/documents/{job_id}/pii/approve",
json=post_body,
headers=api_key_headers,
)
assert response.status_code == 409
assert "processing_queued" in response.json()["detail"]
mock_approval_service.quick_approve.assert_not_awaited()
finally:
app.dependency_overrides.clear()