1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212from __future__ import annotations
from unittest.mock import AsyncMock, patch
import pytest
class TestFeedbackClient:
@pytest.fixture(autouse=True)
def setup(self):
"""Reset module-level singleton for each test."""
# Import fresh each time with mocked settings
pass
@pytest.mark.asyncio
async def test_disabled_by_default(self):
"""When feedback_enabled=False, no HTTP calls are made."""
with patch("src.services.feedback_client.settings") as mock_settings:
mock_settings.feedback_enabled = False
mock_settings.feedback_service_url = None
from src.services.feedback_client import FeedbackClient
client = FeedbackClient()
with patch("httpx.AsyncClient") as mock_httpx:
await client.track_edit(original_text="a", corrected_text="b")
mock_httpx.assert_not_called()
@pytest.mark.asyncio
async def test_track_edit_sends_post(self):
"""When enabled, track_edit sends a POST request."""
with patch("src.services.feedback_client.settings") as mock_settings:
mock_settings.feedback_enabled = True
mock_settings.feedback_service_url = "http://feedback:8090"
mock_settings.feedback_service_api_key = type("S", (), {"get_secret_value": lambda self: "test-key"})()
mock_settings.api_key_header_name = "X-API-Key"
from src.services.feedback_client import FeedbackClient
client = FeedbackClient()
mock_response = AsyncMock()
mock_client_instance = AsyncMock()
mock_client_instance.post = AsyncMock(return_value=mock_response)
mock_client_instance.__aenter__ = AsyncMock(return_value=mock_client_instance)
mock_client_instance.__aexit__ = AsyncMock(return_value=False)
with patch("httpx.AsyncClient", return_value=mock_client_instance):
await client.track_edit(
document_id="doc-1",
original_text="old",
corrected_text="new",
page=3,
)
mock_client_instance.post.assert_called_once()
call_args = mock_client_instance.post.call_args
assert call_args[0][0] == "http://feedback:8090/api/v1/feedback"
assert call_args[1]["json"]["feedback_type"] == "user_edit"
@pytest.mark.asyncio
async def test_report_issue_sends_post(self):
"""When enabled, report_issue sends a POST request."""
with patch("src.services.feedback_client.settings") as mock_settings:
mock_settings.feedback_enabled = True
mock_settings.feedback_service_url = "http://feedback:8090"
mock_settings.feedback_service_api_key = type("S", (), {"get_secret_value": lambda self: "test-key"})()
mock_settings.api_key_header_name = "X-API-Key"
from src.services.feedback_client import FeedbackClient
client = FeedbackClient()
mock_client_instance = AsyncMock()
mock_client_instance.post = AsyncMock(return_value=AsyncMock())
mock_client_instance.__aenter__ = AsyncMock(return_value=mock_client_instance)
mock_client_instance.__aexit__ = AsyncMock(return_value=False)
with patch("httpx.AsyncClient", return_value=mock_client_instance):
await client.report_issue(
document_id="doc-1",
category="accessibility",
description="Alt text missing",
)
call_args = mock_client_instance.post.call_args
assert call_args[1]["json"]["feedback_type"] == "issue_report"
assert call_args[1]["json"]["category"] == "accessibility"
@pytest.mark.asyncio
async def test_error_swallowed(self):
"""HTTP errors should be logged but not raised."""
with patch("src.services.feedback_client.settings") as mock_settings:
mock_settings.feedback_enabled = True
mock_settings.feedback_service_url = "http://feedback:8090"
mock_settings.feedback_service_api_key = type("S", (), {"get_secret_value": lambda self: "test-key"})()
mock_settings.api_key_header_name = "X-API-Key"
from src.services.feedback_client import FeedbackClient
client = FeedbackClient()
with patch("httpx.AsyncClient", side_effect=Exception("connection refused")):
# Should not raise
await client.track_edit(original_text="a", corrected_text="b")
@pytest.mark.asyncio
async def test_upload_document_sends_multipart(self):
"""When enabled, upload_document sends a multipart POST."""
with patch("src.services.feedback_client.settings") as mock_settings:
mock_settings.feedback_enabled = True
mock_settings.feedback_service_url = "http://feedback:8090"
mock_settings.feedback_service_api_key = type("S", (), {"get_secret_value": lambda self: "test-key"})()
mock_settings.api_key_header_name = "X-API-Key"
from src.services.feedback_client import FeedbackClient
client = FeedbackClient()
mock_response = AsyncMock()
mock_response.status_code = 200
mock_response.json = lambda: {"ref": "abcdef012345"}
mock_client_instance = AsyncMock()
mock_client_instance.post = AsyncMock(return_value=mock_response)
mock_client_instance.__aenter__ = AsyncMock(return_value=mock_client_instance)
mock_client_instance.__aexit__ = AsyncMock(return_value=False)
with patch("httpx.AsyncClient", return_value=mock_client_instance):
ref = await client.upload_document(b"%PDF-1.4 test", "test.pdf")
assert ref == "abcdef012345"
mock_client_instance.post.assert_called_once()
call_args = mock_client_instance.post.call_args
assert call_args[0][0] == "http://feedback:8090/api/v1/documents"
@pytest.mark.asyncio
async def test_upload_document_disabled_returns_none(self):
"""When feedback is disabled, upload_document returns None without HTTP call."""
with patch("src.services.feedback_client.settings") as mock_settings:
mock_settings.feedback_enabled = False
mock_settings.feedback_service_url = None
from src.services.feedback_client import FeedbackClient
client = FeedbackClient()
with patch("httpx.AsyncClient") as mock_httpx:
ref = await client.upload_document(b"%PDF-1.4 test", "test.pdf")
assert ref is None
mock_httpx.assert_not_called()
@pytest.mark.asyncio
async def test_upload_document_error_returns_none(self):
"""Upload errors should be swallowed and return None."""
with patch("src.services.feedback_client.settings") as mock_settings:
mock_settings.feedback_enabled = True
mock_settings.feedback_service_url = "http://feedback:8090"
mock_settings.feedback_service_api_key = type("S", (), {"get_secret_value": lambda self: "test-key"})()
mock_settings.api_key_header_name = "X-API-Key"
from src.services.feedback_client import FeedbackClient
client = FeedbackClient()
with patch("httpx.AsyncClient", side_effect=Exception("connection refused")):
ref = await client.upload_document(b"%PDF-1.4 test", "test.pdf")
assert ref is None
@pytest.mark.asyncio
async def test_track_edit_with_document_ref(self):
"""track_edit should include document_ref in payload."""
with patch("src.services.feedback_client.settings") as mock_settings:
mock_settings.feedback_enabled = True
mock_settings.feedback_service_url = "http://feedback:8090"
mock_settings.feedback_service_api_key = type("S", (), {"get_secret_value": lambda self: "test-key"})()
mock_settings.api_key_header_name = "X-API-Key"
from src.services.feedback_client import FeedbackClient
client = FeedbackClient()
mock_client_instance = AsyncMock()
mock_client_instance.post = AsyncMock(return_value=AsyncMock())
mock_client_instance.__aenter__ = AsyncMock(return_value=mock_client_instance)
mock_client_instance.__aexit__ = AsyncMock(return_value=False)
with patch("httpx.AsyncClient", return_value=mock_client_instance):
await client.track_edit(
original_text="old",
corrected_text="new",
document_ref="abcdef012345",
)
call_args = mock_client_instance.post.call_args
assert call_args[1]["json"]["document_ref"] == "abcdef012345"
@pytest.mark.asyncio
async def test_batch_sends_items_array(self):
"""Batch edits should send as items array."""
with patch("src.services.feedback_client.settings") as mock_settings:
mock_settings.feedback_enabled = True
mock_settings.feedback_service_url = "http://feedback:8090"
mock_settings.feedback_service_api_key = type("S", (), {"get_secret_value": lambda self: "test-key"})()
mock_settings.api_key_header_name = "X-API-Key"
from src.services.feedback_client import FeedbackClient
client = FeedbackClient()
mock_client_instance = AsyncMock()
mock_client_instance.post = AsyncMock(return_value=AsyncMock())
mock_client_instance.__aenter__ = AsyncMock(return_value=mock_client_instance)
mock_client_instance.__aexit__ = AsyncMock(return_value=False)
with patch("httpx.AsyncClient", return_value=mock_client_instance):
edits = [
{"feedback_type": "user_edit", "original_text": "a", "corrected_text": "b"},
{"feedback_type": "user_edit", "original_text": "c", "corrected_text": "d"},
]
await client.track_edits_batch(edits)
call_args = mock_client_instance.post.call_args
assert "items" in call_args[1]["json"]
assert len(call_args[1]["json"]["items"]) == 2