1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336"""Integration tests for approval workflow API endpoints."""
from datetime import UTC, datetime, timedelta
from unittest.mock import AsyncMock, MagicMock, patch
import pytest
from httpx import ASGITransport, AsyncClient
from src.main import app
@pytest.fixture
def valid_job_data():
"""Valid job data for approval workflow."""
return {
"job_id": "550e8400-e29b-41d4-a716-446655440000",
"s3_key": "temp/test-doc.pdf",
"status": "awaiting_approval",
"approval_token": "valid-token-abc123",
"approval_expires_at": (datetime.now(UTC) + timedelta(hours=2)).isoformat(),
"created_at": datetime.now(UTC).isoformat(),
"pii_findings": [{"entity_type": "EMAIL_ADDRESS", "text": "student@example.com", "score": 0.95}],
}
@pytest.fixture
def expired_job_data():
"""Job data with expired approval token."""
return {
"job_id": "expired-job-456",
"s3_key": "temp/expired-doc.pdf",
"status": "awaiting_approval",
"approval_token": "expired-token-xyz",
"approval_expires_at": (datetime.now(UTC) - timedelta(hours=1)).isoformat(),
"created_at": datetime.now(UTC).isoformat(),
"pii_findings": [],
}
@pytest.mark.asyncio
async def test_get_review_details_valid_token(valid_job_data, api_key_headers):
"""Test GET /api/v1/approval/{token}/review with valid token."""
token = valid_job_data["approval_token"]
with (
patch("src.api.approval.get_redis_client") as mock_redis_dep,
patch("src.api.approval.get_s3_client") as mock_s3_dep,
patch("src.api.approval.JobService") as mock_job_service_class,
):
# Mock Redis client
mock_redis = AsyncMock()
mock_redis.keys.return_value = [b"eq-pdf:job:test-job-123"]
mock_redis_dep.return_value = mock_redis
# Mock S3 client
mock_s3 = AsyncMock()
mock_s3_dep.return_value = mock_s3
# Mock JobService (with new O(1) lookup method)
mock_job_service = AsyncMock()
mock_job_service.get_job.return_value = valid_job_data
mock_job_service.get_job_by_approval_token.return_value = valid_job_data
mock_job_service_class.return_value = mock_job_service
# Make request with API key headers
async with AsyncClient(transport=ASGITransport(app=app), base_url="http://test") as client:
response = await client.get(f"/api/v1/approval/{token}/review", headers=api_key_headers)
# Assert
assert response.status_code == 200
data = response.json()
assert data["job_id"] == valid_job_data["job_id"]
assert data["status"] == "awaiting_approval"
assert len(data["pii_findings"]) == 1
assert data["pii_findings"][0]["entity_type"] == "EMAIL_ADDRESS"
@pytest.mark.asyncio
async def test_get_review_details_invalid_token(api_key_headers):
"""Test GET /api/v1/approval/{token}/review with invalid token."""
with (
patch("src.api.approval.get_redis_client") as mock_redis_dep,
patch("src.api.approval.get_s3_client") as mock_s3_dep,
):
# Mock Redis - no matching job
mock_redis = AsyncMock()
mock_redis.keys.return_value = []
mock_redis_dep.return_value = mock_redis
mock_s3 = AsyncMock()
mock_s3_dep.return_value = mock_s3
# Make request with API key headers
async with AsyncClient(transport=ASGITransport(app=app), base_url="http://test") as client:
response = await client.get("/api/v1/approval/invalid-token-999/review", headers=api_key_headers)
# Assert
assert response.status_code == 404
assert "Invalid or expired" in response.json()["detail"]
@pytest.mark.asyncio
async def test_get_review_details_expired_token(expired_job_data, api_key_headers):
"""Test GET /api/v1/approval/{token}/review with expired token."""
token = expired_job_data["approval_token"]
with (
patch("src.api.approval.get_redis_client") as mock_redis_dep,
patch("src.api.approval.get_s3_client") as mock_s3_dep,
patch("src.api.approval.JobService") as mock_job_service_class,
):
# Mock Redis client
mock_redis = AsyncMock()
mock_redis_dep.return_value = mock_redis
# Mock S3
mock_s3 = AsyncMock()
mock_s3_dep.return_value = mock_s3
# Mock JobService with expired data
mock_job_service = AsyncMock()
mock_job_service.get_job_by_approval_token.return_value = expired_job_data
mock_job_service_class.return_value = mock_job_service
# Make request with API key headers
async with AsyncClient(transport=ASGITransport(app=app), base_url="http://test") as client:
response = await client.get(f"/api/v1/approval/{token}/review", headers=api_key_headers)
# Assert
assert response.status_code == 404
assert "Invalid or expired" in response.json()["detail"]
@pytest.mark.asyncio
async def test_submit_approval_approved_decision(valid_job_data, api_key_headers):
"""Test POST /api/v1/approval/{token}/decision with approved decision."""
import json
from src.dependencies import get_redis_client, get_s3_client, get_s3_url_service, get_storage_service
# Add updated_at field required by Job model
valid_job_data["updated_at"] = valid_job_data["created_at"]
token = valid_job_data["approval_token"]
job_id = valid_job_data["job_id"]
decision_payload = {
"decision": "approved",
"justification": "Instructor contact information is acceptable for course materials",
"reviewed_by": "faculty@uic.edu",
}
# Prepare job data for Redis (pii_findings must be JSON string)
redis_job_data = valid_job_data.copy()
redis_job_data["pii_findings"] = json.dumps(valid_job_data["pii_findings"])
# Mock Redis client with proper method returns
mock_redis = AsyncMock()
# register_script is a SYNC method that returns a callable Script object.
# AsyncMock would return a coroutine (not callable), so use MagicMock.
mock_redis.register_script = MagicMock(return_value=AsyncMock())
# For get_job_by_approval_token -> get job_id from token
mock_redis.get.return_value = job_id
# For get_job -> get full job data (with pii_findings as JSON string)
# Note: hgetall gets called multiple times, so we use side_effect to return fresh copies
def return_redis_job(*args, **kwargs):
data = valid_job_data.copy()
data["pii_findings"] = json.dumps(valid_job_data["pii_findings"])
return data
mock_redis.hgetall.side_effect = return_redis_job
# For decision submission (no longer uses lpush, uses direct processing)
mock_redis.zrem.return_value = 1
mock_redis.hset.return_value = 1
mock_redis.set.return_value = True # For distributed lock acquisition
mock_redis.delete.return_value = 1 # For lock release
# Mock S3 client
mock_s3 = AsyncMock()
# Mock storage and URL services for processing trigger
mock_storage = AsyncMock()
mock_s3_url = AsyncMock()
# Override dependencies
app.dependency_overrides[get_redis_client] = lambda: mock_redis
app.dependency_overrides[get_s3_client] = lambda: mock_s3
app.dependency_overrides[get_storage_service] = lambda: mock_storage
app.dependency_overrides[get_s3_url_service] = lambda: mock_s3_url
# Mock DocumentProcessingService to prevent actual processing
# The import happens inside the method, so we patch where it's defined
with patch("src.services.document_processing_service.DocumentProcessingService") as mock_processing_class:
mock_processing_service = AsyncMock()
mock_processing_service.process_document = AsyncMock()
mock_processing_class.return_value = mock_processing_service
try:
# Make request with API key headers
async with AsyncClient(transport=ASGITransport(app=app), base_url="http://test") as client:
response = await client.post(
f"/api/v1/approval/{token}/decision", json=decision_payload, headers=api_key_headers
)
# Assert
assert response.status_code == 200
data = response.json()
assert data["decision"] == "approved"
assert data["job_id"] == valid_job_data["job_id"]
assert "approved" in data["message"]
# Verify Lua script was called for status update (quick_approve uses update_job_status)
mock_redis.register_script.assert_called() # Lua scripts registered in JobService.__init__
finally:
# Clean up overrides
app.dependency_overrides.clear()
@pytest.mark.asyncio
async def test_submit_approval_denied_decision(valid_job_data, api_key_headers):
"""Test POST /api/v1/approval/{token}/decision with denied decision."""
token = valid_job_data["approval_token"]
decision_payload = {
"decision": "denied",
"justification": "Contains student PII that cannot be processed per university policy",
"reviewed_by": "admin@uic.edu",
}
with (
patch("src.api.approval.get_redis_client") as mock_redis_dep,
patch("src.api.approval.get_s3_client") as mock_s3_dep,
patch("src.api.approval.JobService") as mock_job_service_class,
patch("src.api.approval.QueueService") as mock_queue_service_class,
patch("src.services.cleanup_service.CleanupService.cleanup_job_files", new_callable=AsyncMock) as mock_cleanup,
):
# Mock Redis client
mock_redis = AsyncMock()
mock_redis.keys.return_value = [b"eq-pdf:job:test-job-123"]
mock_redis.zrem.return_value = 1
mock_redis.hset.return_value = 1
mock_redis_dep.return_value = mock_redis
# Mock S3 client
mock_s3 = AsyncMock()
mock_s3_dep.return_value = mock_s3
# Mock JobService
mock_job_service = AsyncMock()
mock_job_service.get_job.return_value = valid_job_data
mock_job_service.get_job_by_approval_token.return_value = valid_job_data
mock_job_service_class.return_value = mock_job_service
# Mock QueueService
mock_queue_service = AsyncMock()
mock_queue_service_class.return_value = mock_queue_service
# Mock cleanup service
mock_cleanup.return_value = True
# Make request with API key headers
async with AsyncClient(transport=ASGITransport(app=app), base_url="http://test") as client:
response = await client.post(
f"/api/v1/approval/{token}/decision", json=decision_payload, headers=api_key_headers
)
# Assert
assert response.status_code == 200
data = response.json()
assert data["decision"] == "denied"
assert data["job_id"] == valid_job_data["job_id"]
assert "denied" in data["message"]
# Verify cleanup was called
mock_cleanup.assert_called_once()
@pytest.mark.asyncio
async def test_submit_approval_invalid_token(api_key_headers):
"""Test POST /api/v1/approval/{token}/decision with invalid token."""
from src.dependencies import get_redis_client, get_s3_client, get_s3_url_service, get_storage_service
decision_payload = {
"decision": "approved",
"justification": "Test justification with enough characters",
"reviewed_by": "test@test.com",
}
# Mock Redis - return None for token lookup (no matching job)
mock_redis = AsyncMock()
mock_redis.get.return_value = None # Token lookup returns nothing
mock_s3 = AsyncMock()
mock_storage = AsyncMock()
mock_s3_url = AsyncMock()
# Use dependency overrides
app.dependency_overrides[get_redis_client] = lambda: mock_redis
app.dependency_overrides[get_s3_client] = lambda: mock_s3
app.dependency_overrides[get_storage_service] = lambda: mock_storage
app.dependency_overrides[get_s3_url_service] = lambda: mock_s3_url
try:
# Make request with API key headers
async with AsyncClient(transport=ASGITransport(app=app), base_url="http://test") as client:
response = await client.post(
"/api/v1/approval/invalid-token/decision", json=decision_payload, headers=api_key_headers
)
# Assert
assert response.status_code == 404
assert "Invalid or expired" in response.json()["detail"]
finally:
app.dependency_overrides.clear()
@pytest.mark.asyncio
async def test_submit_approval_validation_errors(api_key_headers):
"""Test POST /api/v1/approval/{token}/decision with invalid payload."""
token = "valid-token-abc"
# Missing required field
invalid_payload = {
"decision": "approved",
"justification": "Too short", # Less than 10 characters
}
# Make request with API key headers
async with AsyncClient(transport=ASGITransport(app=app), base_url="http://test") as client:
response = await client.post(
f"/api/v1/approval/{token}/decision",
json=invalid_payload,
headers=api_key_headers,
)
# Assert validation error
assert response.status_code == 422 # Unprocessable Entity