1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414"""Tests for OrphanService - Orphaned job detection and cleanup."""
from datetime import UTC, datetime, timedelta
from unittest.mock import AsyncMock
import pytest
from src.services.orphan_service import OrphanService
@pytest.fixture
def mock_job_service(mocker):
"""Create mock JobService."""
service = mocker.AsyncMock()
service.list_all_jobs = AsyncMock(return_value=[])
service.list_jobs_updated_before = AsyncMock(return_value=[])
service.get_job_status = AsyncMock(return_value=None)
service.update_job_status = AsyncMock()
service.cleanup_old_job = AsyncMock()
return service
@pytest.fixture
def mock_s3_cleanup_service(mocker):
"""Create mock S3CleanupService."""
service = mocker.AsyncMock()
service.cleanup_temp_files_for_job = AsyncMock(return_value=True)
return service
@pytest.fixture
def mock_metrics_service(mocker):
"""Create mock MetricsService."""
service = mocker.AsyncMock()
service.increment_metric = AsyncMock()
return service
@pytest.fixture
def orphan_service(
mock_job_service,
mock_s3_cleanup_service,
mock_metrics_service
):
"""Create OrphanService with mocked dependencies."""
return OrphanService(
job_service=mock_job_service,
s3_cleanup_service=mock_s3_cleanup_service,
metrics_service=mock_metrics_service
)
@pytest.fixture
def old_completed_job():
"""Sample old completed job (35 days ago)."""
return {
"job_id": "old-job-123",
"status": "completed",
"s3_key": "temp/old-job-123.pdf",
"created_at": (datetime.now(UTC) - timedelta(days=35)).isoformat(),
"result_url": "https://s3.example.com/results/old-job-123/output.md"
}
@pytest.fixture
def old_failed_job():
"""Sample old failed job (40 days ago)."""
return {
"job_id": "failed-job-456",
"status": "failed",
"s3_key": "temp/failed-job-456.pdf",
"created_at": (datetime.now(UTC) - timedelta(days=40)).isoformat(),
"error_message": "Processing failed"
}
@pytest.fixture
def recent_completed_job():
"""Sample recent completed job (5 days ago)."""
return {
"job_id": "recent-job-789",
"status": "completed",
"s3_key": "temp/recent-job-789.pdf",
"created_at": (datetime.now(UTC) - timedelta(days=5)).isoformat(),
"result_url": "https://s3.example.com/results/recent-job-789/output.md"
}
@pytest.fixture
def stuck_processing_job():
"""Sample job stuck in processing (3 hours ago)."""
return {
"job_id": "stuck-job-111",
"status": "processing",
"s3_key": "temp/stuck-job-111.pdf",
"created_at": (datetime.now(UTC) - timedelta(hours=3)).isoformat()
}
@pytest.fixture
def normal_processing_job():
"""Sample job normally processing (30 minutes ago)."""
return {
"job_id": "normal-job-222",
"status": "processing",
"s3_key": "temp/normal-job-222.pdf",
"created_at": (datetime.now(UTC) - timedelta(minutes=30)).isoformat()
}
class TestCleanupOldCompletedJobs:
"""Tests for cleanup_old_completed_jobs method."""
@pytest.mark.asyncio
async def test_no_jobs_in_redis(
self,
orphan_service,
mock_job_service
):
"""Test when no jobs exist in Redis."""
mock_job_service.list_all_jobs.return_value = []
result = await orphan_service.cleanup_old_completed_jobs()
assert result["jobs_cleaned"] == 0
assert result["errors"] == 0
@pytest.mark.asyncio
async def test_cleanup_single_old_job(
self,
orphan_service,
mock_job_service,
mock_s3_cleanup_service,
mock_metrics_service,
old_completed_job
):
"""Test cleaning up a single old completed job."""
mock_job_service.list_all_jobs.return_value = ["old-job-123"]
mock_job_service.get_job_status.return_value = old_completed_job
result = await orphan_service.cleanup_old_completed_jobs()
assert result["jobs_cleaned"] == 1
assert result["errors"] == 0
mock_s3_cleanup_service.cleanup_temp_files_for_job.assert_called_once_with(
"old-job-123"
)
mock_job_service.cleanup_old_job.assert_called_once_with("old-job-123")
mock_metrics_service.increment_metric.assert_called_once_with(
"old_jobs_cleaned", 1
)
@pytest.mark.asyncio
async def test_skip_recent_completed_jobs(
self,
orphan_service,
mock_job_service,
recent_completed_job
):
"""Test that recent completed jobs are not cleaned up."""
mock_job_service.list_all_jobs.return_value = ["recent-job-789"]
mock_job_service.get_job_status.return_value = recent_completed_job
result = await orphan_service.cleanup_old_completed_jobs()
assert result["jobs_cleaned"] == 0
mock_job_service.cleanup_old_job.assert_not_called()
@pytest.mark.asyncio
async def test_cleanup_multiple_old_jobs(
self,
orphan_service,
mock_job_service,
old_completed_job,
old_failed_job
):
"""Test cleaning up multiple old jobs."""
mock_job_service.list_all_jobs.return_value = ["old-job-123", "failed-job-456"]
def get_job_status_side_effect(job_id):
if job_id == "old-job-123":
return old_completed_job
return old_failed_job
mock_job_service.get_job_status.side_effect = get_job_status_side_effect
result = await orphan_service.cleanup_old_completed_jobs()
assert result["jobs_cleaned"] == 2
assert result["errors"] == 0
@pytest.mark.asyncio
async def test_skip_active_jobs(
self,
orphan_service,
mock_job_service
):
"""Test that active jobs (processing, awaiting_approval) are not cleaned."""
mock_job_service.list_all_jobs.return_value = ["active-job"]
mock_job_service.get_job_status.return_value = {
"job_id": "active-job",
"status": "processing",
"created_at": (datetime.now(UTC) - timedelta(days=40)).isoformat()
}
result = await orphan_service.cleanup_old_completed_jobs()
# Should not cleanup active jobs even if old
assert result["jobs_cleaned"] == 0
@pytest.mark.asyncio
async def test_partial_cleanup_failure(
self,
orphan_service,
mock_job_service,
mock_s3_cleanup_service,
old_completed_job,
old_failed_job
):
"""Test handling partial cleanup failures."""
mock_job_service.list_all_jobs.return_value = ["job-1", "job-2"]
def get_job_status_side_effect(job_id):
if job_id == "job-1":
return old_completed_job
return old_failed_job
mock_job_service.get_job_status.side_effect = get_job_status_side_effect
# First cleanup succeeds, second fails
async def cleanup_side_effect(job_id):
if job_id == "job-1":
return None
raise Exception("Cleanup failed")
mock_job_service.cleanup_old_job.side_effect = cleanup_side_effect
result = await orphan_service.cleanup_old_completed_jobs()
assert result["jobs_cleaned"] == 1
assert result["errors"] == 1
class TestCleanupStuckProcessingJobs:
"""Tests for cleanup_stuck_processing_jobs method."""
@pytest.mark.asyncio
async def test_no_stuck_jobs(
self,
orphan_service,
mock_job_service,
normal_processing_job
):
"""Test when no jobs are stuck."""
mock_job_service.list_all_jobs.return_value = ["normal-job-222"]
mock_job_service.get_job_status.return_value = normal_processing_job
result = await orphan_service.cleanup_stuck_processing_jobs()
assert result["jobs_failed"] == 0
assert result["errors"] == 0
@pytest.mark.asyncio
async def test_fail_stuck_processing_job(
self,
orphan_service,
mock_job_service,
mock_s3_cleanup_service,
mock_metrics_service,
stuck_processing_job
):
"""Test failing a job stuck in processing."""
mock_job_service.list_all_jobs.return_value = ["stuck-job-111"]
mock_job_service.get_job_status.return_value = stuck_processing_job
result = await orphan_service.cleanup_stuck_processing_jobs()
assert result["jobs_failed"] == 1
assert result["errors"] == 0
mock_job_service.update_job_status.assert_called_once_with(
"stuck-job-111",
status="failed",
error_message="Job exceeded maximum processing time and was terminated"
)
mock_s3_cleanup_service.cleanup_temp_files_for_job.assert_called_once_with(
"stuck-job-111"
)
mock_metrics_service.increment_metric.assert_called_once_with(
"stuck_jobs_failed", 1
)
@pytest.mark.asyncio
async def test_fail_stuck_pii_scanning_job(
self,
orphan_service,
mock_job_service
):
"""Test failing a job stuck in PII scanning."""
stuck_pii_job = {
"job_id": "stuck-pii-333",
"status": "pii_scanning",
"created_at": (datetime.now(UTC) - timedelta(hours=3)).isoformat()
}
mock_job_service.list_all_jobs.return_value = ["stuck-pii-333"]
mock_job_service.get_job_status.return_value = stuck_pii_job
result = await orphan_service.cleanup_stuck_processing_jobs()
assert result["jobs_failed"] == 1
mock_job_service.update_job_status.assert_called_once()
@pytest.mark.asyncio
async def test_skip_completed_jobs(
self,
orphan_service,
mock_job_service,
old_completed_job
):
"""Test that completed jobs are not marked as stuck."""
mock_job_service.list_all_jobs.return_value = ["old-job-123"]
mock_job_service.get_job_status.return_value = old_completed_job
result = await orphan_service.cleanup_stuck_processing_jobs()
assert result["jobs_failed"] == 0
mock_job_service.update_job_status.assert_not_called()
@pytest.mark.asyncio
async def test_multiple_stuck_jobs(
self,
orphan_service,
mock_job_service,
stuck_processing_job
):
"""Test handling multiple stuck jobs."""
mock_job_service.list_all_jobs.return_value = ["stuck-1", "stuck-2", "stuck-3"]
mock_job_service.get_job_status.return_value = stuck_processing_job
result = await orphan_service.cleanup_stuck_processing_jobs()
assert result["jobs_failed"] == 3
assert mock_job_service.update_job_status.call_count == 3
@pytest.mark.asyncio
async def test_cleanup_failure_increments_errors(
self,
orphan_service,
mock_job_service,
mock_metrics_service,
stuck_processing_job
):
"""Test that cleanup failures increment error metric."""
mock_job_service.list_all_jobs.return_value = ["stuck-job"]
mock_job_service.get_job_status.return_value = stuck_processing_job
mock_job_service.update_job_status.side_effect = Exception("Update failed")
result = await orphan_service.cleanup_stuck_processing_jobs()
assert result["jobs_failed"] == 0
assert result["errors"] == 1
mock_metrics_service.increment_metric.assert_called_with(
"orphan_cleanup_errors", 1
)
class TestShouldCleanupJob:
"""Tests for _should_cleanup_job method."""
@pytest.mark.asyncio
async def test_old_completed_job_should_cleanup(
self,
orphan_service,
mock_job_service,
old_completed_job
):
"""Test that old completed jobs should be cleaned."""
mock_job_service.get_job_status.return_value = old_completed_job
cutoff = datetime.now(UTC) - timedelta(days=30)
result = await orphan_service._should_cleanup_job("old-job-123", cutoff)
assert result is True
@pytest.mark.asyncio
async def test_recent_job_should_not_cleanup(
self,
orphan_service,
mock_job_service,
recent_completed_job
):
"""Test that recent jobs should not be cleaned."""
mock_job_service.get_job_status.return_value = recent_completed_job
cutoff = datetime.now(UTC) - timedelta(days=30)
result = await orphan_service._should_cleanup_job("recent-job-789", cutoff)
assert result is False
@pytest.mark.asyncio
async def test_missing_job_should_cleanup(
self,
orphan_service,
mock_job_service
):
"""Test that missing jobs should be cleaned (removed from tracking)."""
mock_job_service.get_job_status.return_value = None
cutoff = datetime.now(UTC) - timedelta(days=30)
result = await orphan_service._should_cleanup_job("missing-job", cutoff)
assert result is True